Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ringcentral-phone: added zap stanza and desc #99161

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

alexg0
Copy link
Contributor

@alexg0 alexg0 commented Feb 1, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@alexg0 alexg0 mentioned this pull request Feb 1, 2021
@miccal
Copy link
Member

miccal commented Feb 1, 2021

Thank you @alexg0.

@miccal miccal merged commit 8cb2b02 into Homebrew:master Feb 1, 2021
@alexg0 alexg0 deleted the ringcentral-phone-zap branch February 2, 2021 19:14
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants