Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new cask evkey #99498

Merged
merged 3 commits into from
Mar 4, 2021
Merged

add new cask evkey #99498

merged 3 commits into from
Mar 4, 2021

Conversation

reishou
Copy link
Contributor

@reishou reishou commented Feb 8, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@miccal
Copy link
Member

miccal commented Feb 9, 2021

Thank you for your contribution to homebrew-cask @reishou.

Could you please try to add a zap stanza, thanks.

@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale Issue which has not received any feedback for some time. label Mar 3, 2021
@reishou
Copy link
Contributor Author

reishou commented Mar 3, 2021

@miccal I updated PR, please check it.

@BrewTestBot BrewTestBot removed the stale Issue which has not received any feedback for some time. label Mar 3, 2021
@miccal miccal removed the awaiting user reply Issue needs response from a user. label Mar 4, 2021
@miccal
Copy link
Member

miccal commented Mar 4, 2021

Thank you @reishou.

@miccal miccal merged commit 77cf442 into Homebrew:master Mar 4, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants