Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Rust 1.78.0 #23676

Closed
wants to merge 2 commits into from
Closed

Conversation

linbingquan
Copy link
Contributor

Update to Rust 1.78.0

@mmastrac
Copy link
Contributor

mmastrac commented May 5, 2024

Unfortunately we will probably not be able to upgrade Rust until llvm/llvm-project#87553 successfully makes it to the LLVM 18 packages on apt.llvm.org.

@mmastrac
Copy link
Contributor

@linbingquan Could you try pulling my changes from #23947 into this PR? I think we'll have to do both at the same time.

@linbingquan
Copy link
Contributor Author

Could you try pulling my changes from #23947 into this PR? I think we'll have to do both at the same time.

Done.

@linbingquan
Copy link
Contributor Author

@mmastrac TBH, I have no idea about this error: test debug linux-aarch64 , I do not know how to fix it...

@devsnek
Copy link
Member

devsnek commented May 24, 2024

@linbingquan i think changing these occurrences in cli/napi might fix it?
from

  let argv: &[v8::Local<v8::Value>] =
    transmute(std::slice::from_raw_parts(argv, argc));

to

  let argv: &[v8::Local<v8::Value>] = if argv.is_null() || argc == 0 {
    &[]
  } else {
    transmute(std::slice::from_raw_parts(argv, argc))
  };

@linbingquan
Copy link
Contributor Author

@linbingquan i think changing these occurrences in cli/napi might fix it? from

  let argv: &[v8::Local<v8::Value>] =
    transmute(std::slice::from_raw_parts(argv, argc));

to

  let argv: &[v8::Local<v8::Value>] = if argv.is_null() || argc == 0 {
    &[]
  } else {
    transmute(std::slice::from_raw_parts(argv, argc))
  };

Thank you for response. This code is able to fix the first error, but it causes other errors, two different errors,

https://github.com/denoland/deno/actions/runs/9240273418/job/25420372710

https://github.com/denoland/deno/actions/runs/9242895741/job/25426316763

@linbingquan
Copy link
Contributor Author

Closed it by #24207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants