-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf 21.2 #105661
Protobuf 21.2 #105661
Conversation
Thanks, @ezzieyguywuf. Could you also do
please?
You can run those commands on a Linux machine too if you have one to test on. |
Done
Ok, I figured out how to do this. It was a bit challenging since I could not immediately figure out how to install from my I'll update the remaining checkboxes on the first post on this PR once the install has completed. |
Formulae that need to be rebuilt due to linkage failures:
|
There's no need; we're a bit more relaxed about following the checklist for version-only changes. |
lol gotcha. any way, it was easy to work through the rest of the list, so I went ahead and did that this morning. Things on my end seem to work well. Please LMK if there's something I need to do to help this move along. I think for starters I'll try rebasing over master again as I seem to be pulling in a bunch of unrelated commits at the moment. |
oh cool! it was merged :-D |
It was not merged, you closed the PR. |
You deleted your branch, so the PR was closed. |
No, I pushed those commits because those formulae needed to be rebuilt. |
🤦♂️ I'll fix it - or rather I'll try. I deleted the fork of homebrew-core too, I might have to open a new PR |
Note: Starting with
v21.0-rc1,
protobuf is using a new versioning scheme.
Signed-off-by: Wolfgang Sanyer wolfgangsanyer@google.com
guidelines for contributing?
commit style guide?
pull requests for the
same formula update/change?
brew install --build-from-source <formula>
, where<formula>
is the name of the formulayou're submitting?
brew test <formula>
, where<formula>
isthe name of the formula you're submitting?
brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does itpass
brew audit --new <formula>
?I do not have a mac to test this on, so I cannot e.g. execute
brew bump-formal-pr