Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 21.2 #105661

Closed
wants to merge 0 commits into from
Closed

Protobuf 21.2 #105661

wants to merge 0 commits into from

Conversation

ezzieyguywuf
Copy link
Contributor

@ezzieyguywuf ezzieyguywuf commented Jul 12, 2022

Note: Starting with
v21.0-rc1,
protobuf is using a new versioning scheme.

Signed-off-by: Wolfgang Sanyer wolfgangsanyer@google.com

  • Have you followed the
    guidelines for contributing?
  • Have you ensured that your commits follow the
    commit style guide?
  • Have you checked that there aren't other open
    pull requests for the
    same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula
    you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is
    the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it
    pass brew audit --new <formula>?

I do not have a mac to test this on, so I cannot e.g. execute brew bump-formal-pr

@carlocab
Copy link
Member

carlocab commented Jul 13, 2022

Thanks, @ezzieyguywuf.

Could you also do

mv Aliases/protobuf@3.19 Aliases/protobuf@21.2

please?

I do not have a mac to test this on, so I cannot e.g. execute brew bump-formal-pr

You can run those commands on a Linux machine too if you have one to test on.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 13, 2022
@ezzieyguywuf
Copy link
Contributor Author

Could you also do

Done

You can run those commands on a Linux machine too if you have one to test on.

Ok, I figured out how to do this. It was a bit challenging since I could not immediately figure out how to install from my bump_protobuf branch, but I worked around this by just copying my changes to my ezzieyguywuf/homebrew-core master branch in order to execute the install.

I'll update the remaining checkboxes on the first post on this PR once the install has completed.

@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Jul 13, 2022
@carlocab
Copy link
Member

Formulae that need to be rebuilt due to linkage failures:

apache-arrow
bear
bloaty
caffe
etcd-cpp-apiv3
fastnetmon
grpc
libphonenumber
libpulsar
libtorch
mavsdk
monero
mosh
mysql
ncnn
netdata
ola
opencv
or-tools
osm-pbf
percona-server
percona-xtrabackup
protobuf-c
protoc-gen-grpc-web
rethinkdb
sysdig
torchvision

@carlocab carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Jul 13, 2022
@carlocab
Copy link
Member

I'll update the remaining checkboxes on the first post on this PR once the install has completed.

There's no need; we're a bit more relaxed about following the checklist for version-only changes.

@ezzieyguywuf
Copy link
Contributor Author

I'll update the remaining checkboxes on the first post on this PR once the install has completed.

There's no need; we're a bit more relaxed about following the checklist for version-only changes.

lol gotcha. any way, it was easy to work through the rest of the list, so I went ahead and did that this morning.

Things on my end seem to work well.

Please LMK if there's something I need to do to help this move along. I think for starters I'll try rebasing over master again as I seem to be pulling in a bunch of unrelated commits at the moment.

@ezzieyguywuf
Copy link
Contributor Author

oh cool! it was merged :-D

@ezzieyguywuf ezzieyguywuf deleted the bump_protobuf branch July 13, 2022 13:37
@SMillerDev
Copy link
Member

It was not merged, you closed the PR.

@carlocab
Copy link
Member

You deleted your branch, so the PR was closed.

@carlocab
Copy link
Member

I think for starters I'll try rebasing over master again as I seem to be pulling in a bunch of unrelated commits at the moment.

No, I pushed those commits because those formulae needed to be rebuilt.

@ezzieyguywuf
Copy link
Contributor Author

🤦‍♂️

I'll fix it - or rather I'll try. I deleted the fork of homebrew-core too, I might have to open a new PR

@ezzieyguywuf ezzieyguywuf mentioned this pull request Jul 13, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants