Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moar 1.9.6 + man page #106321

Closed
wants to merge 1 commit into from
Closed

moar 1.9.6 + man page #106321

wants to merge 1 commit into from

Conversation

walles
Copy link
Contributor

@walles walles commented Jul 21, 2022 •
edited
Loading

Created manually since I wanted to add the man1.install "moar.1" line to moar.rb.

Fixes walles/moar#87.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@walles
moar 1.9.6 + man page
7627536 
Created manually since I wanted to add the `man1.install "moar.1"` line to `moar.rb`.
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Jul 21, 2022
@walles walles mentioned this pull request Jul 21, 2022
Closed
carlocab
carlocab approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab
Copy link
Member

Just mark this as ready for review whenever you're ready.

@walles walles marked this pull request as ready for review July 21, 2022 15:45
@walles
Copy link
Contributor Author

walles commented Jul 21, 2022

Ready!

I just didn't want to bother any human reviewers before CI passed, but I see that didn't really work out :).

Thanks @carlocab!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] man page
3 participants
@walles @carlocab @BrewTestBot