Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smap 0.1.11 (new formula) #106353

Closed
wants to merge 2 commits into from
Closed

smap 0.1.11 (new formula) #106353

wants to merge 2 commits into from

Conversation

b-reich
Copy link
Contributor

@b-reich b-reich commented Jul 21, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jul 21, 2022
Formula/smap.rb Outdated Show resolved Hide resolved
This was referenced Jul 22, 2022
Copy link
Member

@alebcay alebcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @b-reich. Just a few minor requests.

Formula/smap.rb Outdated Show resolved Hide resolved
Formula/smap.rb Outdated Show resolved Hide resolved
@b-reich b-reich requested a review from alebcay July 25, 2022 13:27
Copy link
Member

@alebcay alebcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one minor nitpick for style. The #{} syntax does string interpolation but we try to avoid unnecessary usage where possible.

Formula/smap.rb Outdated Show resolved Hide resolved
Co-authored-by: Caleb Xu <calebcenter@live.com>
@b-reich b-reich requested a review from alebcay July 25, 2022 14:40
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
@b-reich b-reich deleted the smap branch September 16, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants