Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dspdfviewer 1.15 #1314

Closed
wants to merge 1 commit into from
Closed

Conversation

wwwdata
Copy link
Contributor

@wwwdata wwwdata commented May 20, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Updated the version to 1.15 and now also compiles with qt5

system "make", "install"
end
end

test do
assert_match /#{version}/, shell_output("#{bin}/dspdfviewer --version", 1)
assert_match /#{version}/, shell_output("#{bin}/dspdfviewer --version", 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This was changed in dannyedel/dspdfviewer@33aad73. Should make the test succeed now.

@UniqMartin
Copy link
Contributor

Merged in 36373d4. Thank you for this contribution to Homebrew, @wwwdata! 🎉

@UniqMartin UniqMartin mentioned this pull request May 23, 2016
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants