Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageoptim-cli 3.1.7 #135595

Merged
merged 2 commits into from
Jul 2, 2023
Merged

imageoptim-cli 3.1.7 #135595

merged 2 commits into from
Jul 2, 2023

Conversation

p-linnane
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle bump-formula-pr PR was created using `brew bump-formula-pr` macos-only Formula depends on macOS labels Jul 2, 2023
@p-linnane
imageoptim-cli 3.1.7
0669a31 
imageoptim-cli: build with `node@18`
@chenrui333
Copy link
Member

actually, let's see if we can build for arm this time as well. (seems working in my local)

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 2, 2023
@p-linnane
Copy link
Member Author

No luck.

  imageoptim-cli
    * Binaries built for a non-native architecture were installed into imageoptim-cli's prefix.
      The offending files are:
        /opt/homebrew/Cellar/imageoptim-cli/3.1.7/libexec/lib/node_modules/imageoptim-cli/dist/imageoptim	(x86_64)

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 2, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 2, 2023
Closed
@JamieMason
Copy link

Hi @p-linnane @chenrui333
Maybe you can help me as I'm not sure what I need to do. I built version 3.1.7 with https://github.com/vercel/pkg using node18-macos-x64. There is also node18-macos-arm64 but I chose x64 because:

macOS: possible to build x64 on arm64 with Rosetta 2 but not opposite.
– https://github.com/vercel/pkg#targets

I could use the arm64 option if we think that will fix this issue, but will that work on non arm64 macs?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

🤖 An automated task has requested bottles to be published to this PR.

@chenrui333
Copy link
Member

@JamieMason you can read the thread #98451 cc @cho-m

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 2, 2023
@chenrui333
Copy link
Member

For now, we are just going to proceed with the merge, the arm build can be addressed separately.

@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 2, 2023
Merged via the queue into Homebrew:master with commit 6f39568 Jul 2, 2023
@p-linnane p-linnane deleted the bump-imageoptim-cli-3.1.7 branch July 2, 2023 18:37
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS no ARM bottle Formula has no ARM bottle nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-linnane @chenrui333 @JamieMason @BrewTestBot