Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic 1.4.1 #139397

Merged
merged 2 commits into from
Sep 2, 2023
Merged

sonic 1.4.1 #139397

merged 2 commits into from
Sep 2, 2023

Conversation

chenrui333
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 12, 2023
@chenrui333
Copy link
Member Author 

  error: failed to run custom build command for `librocksdb-sys v6.20.3`
  
  Caused by:
    process didn't exit successfully: `/tmp/sonic-20230812-9917-10wj5jb/sonic-1.4.1/target/release/build/librocksdb-sys-551f32dd734153b5/build-script-build` (exit status: 101)
    --- stderr
    thread 'main' panicked at '"enum_(unnamed_at_rocksdb/include/rocksdb/c_h_854_1)" is not a valid Ident', /github/home/.cache/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.66/src/fallback.rs:774:9
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  warning: build failed, waiting for other jobs to finish...
  error: failed to compile `sonic-server v1.4.1 (/tmp/sonic-20230812-9917-10wj5jb/sonic-1.4.1)`, intermediate artifacts can be found at `/tmp/sonic-20230812-9917-10wj5jb/sonic-1.4.1/target`

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 12, 2023
@chenrui333 chenrui333 added the help wanted Task(s) needing PRs from the community or maintainers label Aug 14, 2023
@chenrui333
Copy link
Member Author

/rebase

@danielnachun
Copy link
Member

This error is occurring because an incompatibility between older versions of the bindgen crate and Clang 16. I believe the build should work if you use llvm@15 to build instead of llvm. If that fixes it, we can put a comment that we can try to llvm when the bindgen crate has been updated to a new enough version to work with LLVM >= 16.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 18, 2023
@danielnachun
Copy link
Member

Building with llvm@15 resolves the build failure but now on Intel macOS we're hitting a seemingly unrelated test failure. I don't know why it only fails on Intel macOS and not on ARM macOS or Linux.

@danielnachun danielnachun added test failure CI fails while running the test-do block and removed build failure CI fails while building the software labels Aug 19, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 20, 2023
Closed
@chenrui333
Copy link
Member Author

raised an upstream issue on this, valeriansaliou/sonic#314

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Aug 20, 2023
@cho-m
Copy link
Member

cho-m commented Aug 21, 2023

Just a random attempt but maybe try increasing sleep time given that Intel macOS is slower than ARM macOS.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 2, 2023
@chenrui333 @danielnachun @ZhongRuoyu
sonic 1.4.1
0ed5c6d 
Also, switch to `llvm@15` to work around a `bindgen` error.

Co-authored-by: danielnachun <daniel.nachun@gmail.com>
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@ZhongRuoyu ZhongRuoyu added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers upstream issue An upstream issue report is needed test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 2, 2023
@ZhongRuoyu
Copy link
Member

Just a random attempt but maybe try increasing sleep time given that Intel macOS is slower than ARM macOS.

Yes, that worked. Thanks, @cho-m.

@chenrui333 chenrui333 requested a review from a team September 2, 2023 17:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 2, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 2, 2023
Merged via the queue into Homebrew:master with commit b16023d Sep 2, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
@chenrui333 chenrui333 deleted the bump-sonic-1.4.1 branch January 22, 2024 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@branchvincent branchvincent branchvincent approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenrui333 @danielnachun @cho-m @ZhongRuoyu @branchvincent @BrewTestBot