Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librist 0.2.8 #141455

Closed
wants to merge 1 commit into from
Closed

librist 0.2.8 #141455

wants to merge 1 commit into from

Conversation

hannesbraun
Copy link
Contributor

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Sep 5, 2023
@alebcay
Copy link
Member

alebcay commented Sep 5, 2023 

   ../tools/srp_shared.c:176:21: error: no member named 'st_mtim' in 'struct stat'
          *generation = (buf.st_mtim.tv_sec << 32) | buf.st_mtim.tv_nsec;

Possible workaround/similar issue: facebook/zstd#1872

@alebcay alebcay added the build failure CI fails while building the software label Sep 5, 2023
@ZhongRuoyu
Copy link
Member

st_mtim is simply not available on macOS; it's named st_mtimespec. See also: marlam/mpop#9

@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label Sep 8, 2023
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Sep 8, 2023
@wegank wegank mentioned this pull request Sep 24, 2023
Merged
@hannesbraun @chenrui333
librist 0.2.8
f36576e 
Also, fix build by defining `_POSIX_C_SOURCE` to `200809L`.
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 10, 2023
@SMillerDev
Copy link
Member

Superceded by #150601

@SMillerDev SMillerDev closed this Oct 15, 2023
@hannesbraun hannesbraun deleted the bump-librist-0.2.8 branch October 16, 2023 07:02
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hannesbraun @alebcay @ZhongRuoyu @SMillerDev @chenrui333