libplacebo: fix dependency linkage #153961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?All of libplacebo's dependencies are technically optional, but some of them are essential to calling packages (e.g. mpv). In particular, much of the library's functionality depends on linking against either shaderc or glslang, and being compiled against vulkan headers, but the build won't fail by default in the absence of either.
Currently, we're failing to pull in any of these dependencies in CI builds, for a few different reasons, all of which are resolved here:
pkg-config
; added one-D[dep]=enabled
args, so failures to link deps were ignored; added themThis fixes the usage of libplacebo in mpv (the only current dependent package), which was almost entirely broken previously, at least in CI builds.