Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-runner: revision change for tag v16.6.1 #157047

Closed
wants to merge 1 commit into from
Closed

gitlab-runner: revision change for tag v16.6.1 #157047

wants to merge 1 commit into from

Conversation

RazerM
Copy link

@RazerM RazerM commented Dec 12, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

building gitlab-runner from source fails because they updated the tag: https://gitlab.com/gitlab-org/gitlab-runner/-/compare/07a32dccbbfeb5aa5b42d922d9495685890ac27d...f5da3c5adf55e55004e0dae2a2e1476f8407c087?from_project_id=250833&straight=false

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Dec 12, 2023
@SMillerDev
Copy link
Member

Did they announce this somewhere?
The git manual says re-tagging is "the insane thing" to do so it would be good to validate it was intentional.

@RazerM
Copy link
Author

RazerM commented Dec 12, 2023

@SMillerDev I'm not aware of any announcement. In the diff I've linked, they updated the release date of 16.6.1 in the changelog. It seems their CI was failing so they merged a fix and re-tagged.

@SMillerDev
Copy link
Member

Could you ask if that was actually the case? I'd hate to merge a compromised update just because we assumed it was fine.

@chenrui333 chenrui333 added upstream issue An upstream issue report is needed checksum mismatch SHA-256 doesn't match the download labels Dec 12, 2023
@chenrui333 chenrui333 changed the title Update revision for gitlab-runner v16.6.1 gitlab-runner: revision change for tag v16.6.1 Dec 12, 2023
@RazerM RazerM deleted the gitlab-runner-16.6.1-tag branch December 21, 2023 21:08
@stefanb stefanb mentioned this pull request Jan 14, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
checksum mismatch SHA-256 doesn't match the download go Go use is a significant feature of the PR or issue outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants