Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license-eye: update to use apache archive dist #158005

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

seen in https://github.com/Homebrew/homebrew-core/actions/runs/7284497233/job/19850411474?pr=157782
relates to #157782

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Dec 21, 2023
@chenrui333 chenrui333 added upstream issue An upstream issue report is needed checksum mismatch SHA-256 doesn't match the download CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 21, 2023
@chenrui333
Copy link
Member Author

cc @kezhenxu94 (sorry to tag you in here, but did not find a good way to file an upstream issue, can you confirm if there was release re-tagging happened? Thanks! 🙏 )

@kezhenxu94
Copy link

cc @kezhenxu94 (sorry to tag you in here, but did not find a good way to file an upstream issue, can you confirm if there was release re-tagging happened? Thanks! 🙏 )

Hi, thanks for tagging me for the information. From the ASF release policy we won't retag a release that was announced , but before an announced official release it can happen that we retag a draft release(on GitHub it's not displayed as the latest release), does it have an impact here?

@SMillerDev
Copy link
Member

Do you know if that happened for this release?

We'll need to make sure we don't ship pre-releases @chenrui333

@chenrui333
Copy link
Member Author

cc @kezhenxu94 (sorry to tag you in here, but did not find a good way to file an upstream issue, can you confirm if there was release re-tagging happened? Thanks! 🙏 )

Hi, thanks for tagging me for the information. From the ASF release policy we won't retag a release that was announced , but before an announced official release it can happen that we retag a draft release(on GitHub it's not displayed as the latest release), does it have an impact here?

what is the best place to track the new releases (blog or mailing list)? Thanks!

@chenrui333
Copy link
Member Author

or would this https://archive.apache.org/dist/skywalking/eyes/0.5.0/ a better place (we actually use apache archive for the other apache formulae)?

@kezhenxu94
Copy link

or would this https://archive.apache.org/dist/skywalking/eyes/0.5.0/ a better place (we actually use apache archive for the other apache formulae)?

This is the source of truth of a release in ASF, all current and legacy releases will be in this place so you can safely use this link to track the releases

@chenrui333
Copy link
Member Author

or would this https://archive.apache.org/dist/skywalking/eyes/0.5.0/ a better place (we actually use apache archive for the other apache formulae)?

This is the source of truth of a release in ASF, all current and legacy releases will be in this place so you can safely use this link to track the releases

Sounds great, I will use that then.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title license-eye: update checksum license-eye: update to use apache archive dist Dec 26, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed upstream issue An upstream issue report is needed labels Dec 26, 2023
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 28, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 28, 2023
Merged via the queue into Homebrew:master with commit 59a8760 Dec 28, 2023
12 checks passed
@stefanb stefanb mentioned this pull request Jan 14, 2024
@chenrui333 chenrui333 deleted the license-eye-checksum branch January 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checksum mismatch SHA-256 doesn't match the download CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants