Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-commit-bottles: remove PR positional arg #171201

Merged
merged 1 commit into from
May 8, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented May 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Patches #171085.
closes #171200

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw requested review from MikeMcQuaid and a team as code owners May 8, 2024 19:59
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels May 8, 2024
@woodruffw
Copy link
Member Author

Fix here is based on observed failure in https://github.com/Homebrew/homebrew-core/actions/runs/9007488956/job/24747380143

Run # Don't quote arguments that might be empty; this causes errors when `brew`
Usage: brew pr-upload [options]

Apply the bottle commit and publish bottles to a host.

      --keep-old                   If the formula specifies a rebuild version,
                                   attempt to preserve its value in the
                                   generated DSL.
  -n, --dry-run                    Print what would be done rather than doing
                                   it.
      --no-commit                  Do not generate a new commit before
                                   uploading.
      --warn-on-upload-failure     Warn instead of raising an error if the
                                   bottle upload fails. Useful for repairing
                                   bottle uploads that previously failed.
      --upload-only                Skip running brew bottle before uploading.
      --committer                  Specify a committer name and email in git's
                                   standard author format.
      --root-url                   Use the specified URL as the root of the
                                   bottle's URL instead of Homebrew's default.
      --root-url-using             Use the specified download strategy class for
                                   downloading the bottle's URL instead of
                                   Homebrew's default.
  -d, --debug                      Display any debugging information.
  -q, --quiet                      Make some output more quiet.
  -v, --verbose                    Make some output more verbose.
  -h, --help                       Show this message.

Error: Invalid usage: This command does not take named arguments.
Error: Process completed with exit code 1.

@woodruffw woodruffw requested a review from carlocab May 8, 2024 20:02
@woodruffw woodruffw self-assigned this May 8, 2024
@chenrui333
Copy link
Member

passed my local run

$ brew pr-upload \
    --debug \
    --committer="$BREWTESTBOT_NAME_EMAIL" \
    --root-url="https://ghcr.io/v2/homebrew/core"
Error: No bottle JSON files found in the current working directory
Error: Kernel.exit

@chenrui333 chenrui333 added this pull request to the merge queue May 8, 2024
@chenrui333
Copy link
Member

merging it as it would unblock the release pipeline.

Merged via the queue into Homebrew:master with commit be4c4f1 May 8, 2024
18 checks passed
@woodruffw woodruffw deleted the ww/fix-upload branch May 8, 2024 20:12
@chenrui333
Copy link
Member

the patch works! 💯

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants