Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reprepro 5.4.4 #171471

Closed
wants to merge 1 commit into from
Closed

reprepro 5.4.4 #171471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/autobump.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1849,6 +1849,7 @@ reminiscence
renovate
repo
reposurgeon
reprepro
reproc
restic
resvg
Expand Down
19 changes: 12 additions & 7 deletions Formula/r/reprepro.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class Reprepro < Formula
desc "Debian package repository manager"
homepage "https://salsa.debian.org/debian/reprepro"
url "https://deb.debian.org/debian/pool/main/r/reprepro/reprepro_5.3.1.orig.tar.xz"
sha256 "5a6d48bf1f60cfd3c32eae05b535b334972c1e9d4e62ed886dd54e040e9c1cda"
url "https://deb.debian.org/debian/pool/main/r/reprepro/reprepro_5.4.4.orig.tar.xz"
sha256 "8cf1e1f39bb75e90467f905eda47b0b40c86071a3d696c4470e28f263813cd52"
license "GPL-2.0-only"

livecheck do
Expand Down Expand Up @@ -36,16 +36,21 @@ class Reprepro < Formula
cause "No support for GNU C nested functions"
end

# Replace strcmp2 with strcmp for consistent string comparison
# upstream patch PR, https://salsa.debian.org/debian/reprepro/-/merge_requests/10
patch do
url "https://raw.githubusercontent.com/Homebrew/formula-patches/5426d605c0d6b6bf4c2e315fed7a991f447caf1a/reprepro/5.4.4-strcmp2.patch"
sha256 "cf1aacf08960cb89896a739086d170417820fe894044d0f446b4ff303a1182e5"
end
Comment on lines +39 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the patch is correct; it seems likely to result in UB: https://salsa.debian.org/debian/reprepro/-/blob/21a227f5fb380672ba022d47628895d2f023bde9/globals.h#L97

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I thought the same thing, I will debug a bit today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just missing an

include "globals.h"

somewhere?


def install
system "./autogen.sh"
system "./configure", "--disable-debug",
"--disable-dependency-tracking",
"--disable-silent-rules",
"--prefix=#{prefix}",
system "./configure", "--disable-silent-rules",
"--with-gpgme=#{Formula["gpgme"].opt_lib}",
"--with-libarchive=#{Formula["libarchive"].opt_lib}",
"--with-libbz2=yes",
"--with-liblzma=#{Formula["xz"].opt_lib}"
"--with-liblzma=#{Formula["xz"].opt_lib}",
*std_configure_args
system "make", "install"
end

Expand Down
Loading