Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch-rebottle: consistently plumb inputs #171990

Merged
merged 1 commit into from
May 17, 2024
Merged

dispatch-rebottle: consistently plumb inputs #171990

merged 1 commit into from
May 17, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented May 17, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Puts the inputs into top-level envvars. I've prefixed them with DISPATCH_REBOTTLE_ for consistently, but it can also be made something less verbose 🙂

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw requested a review from p-linnane May 17, 2024 16:18
@woodruffw woodruffw self-assigned this May 17, 2024
@woodruffw woodruffw requested review from MikeMcQuaid and a team as code owners May 17, 2024 16:18
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels May 17, 2024
@woodruffw woodruffw added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 665f4eb May 17, 2024
18 checks passed
@woodruffw woodruffw deleted the ww/via-env branch May 17, 2024 16:28
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants