Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenv: Add completion #172289

Merged
merged 2 commits into from
May 21, 2024
Merged

tenv: Add completion #172289

merged 2 commits into from
May 21, 2024

Conversation

trallnag
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR adds shell completion to the tenv formula. Completion is sourced via tenv completion <shell>.

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label May 21, 2024
Formula/t/tenv.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 21, 2024
tenv Remove unnecessary parameter

Co-authored-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 21, 2024
@chenrui333
Copy link
Member

@trallnag thanks for your first contribution to homebrew-core! 🎉

Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 21, 2024
@kvendingoldo
Copy link
Contributor

@trallnag good idea!

@p-linnane p-linnane removed this pull request from the merge queue due to a manual request May 21, 2024
@p-linnane p-linnane added this pull request to the merge queue May 21, 2024
Merged via the queue into Homebrew:master with commit 63dcf02 May 21, 2024
14 checks passed
@@ -31,6 +32,7 @@ def install
%w[tenv terraform terragrunt tf tofu atmos].each do |f|
system "go", "build", *std_go_args(ldflags:, output: bin/f), "./cmd/#{f}"
end
generate_completions_from_executable(bin/"tenv", "completion")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought, this only generates the completions for tenv, you can check my commit in the tenv formula PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean completions for the tools installed and managed by tenv, like terraform and terragrunt? Thinks this could be added to the formula?

Tenv installs the tools to various locations depending on defaults and environment variables. Furthermore out of the box no tools are installed (except tenv itself).

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age shell-completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants