-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tenv: Add completion #172289
tenv: Add completion #172289
Conversation
tenv Remove unnecessary parameter Co-authored-by: Rui Chen <rui@chenrui.dev>
@trallnag thanks for your first contribution to homebrew-core! 🎉 |
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
🤖 An automated task has requested bottles to be published to this PR. |
@trallnag good idea! |
@@ -31,6 +32,7 @@ def install | |||
%w[tenv terraform terragrunt tf tofu atmos].each do |f| | |||
system "go", "build", *std_go_args(ldflags:, output: bin/f), "./cmd/#{f}" | |||
end | |||
generate_completions_from_executable(bin/"tenv", "completion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a second thought, this only generates the completions for tenv, you can check my commit in the tenv formula PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean completions for the tools installed and managed by tenv, like terraform and terragrunt? Thinks this could be added to the formula?
Tenv installs the tools to various locations depending on defaults and environment variables. Furthermore out of the box no tools are installed (except tenv itself).
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This PR adds shell completion to the tenv formula. Completion is sourced via
tenv completion <shell>
.