Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
filter-branch
when there are local changesThis PR changes filter-branch to detect any local changes so working/staged changes aren't lost.
A future PR should include changes to have the working set just be applied over the result of
dolt filter-branch
.partially addresses:
filter-branch
destroys working and staged roots dolthub/dolt#7891go-mysql-server
Nodes that return zero or one row don't need a beefy channel/wait group setup to execute. They just need to grab the first row and close the iterator. There are several nodes that incorrectly reported their schemas previously, which I've updated to be more accurate. There are some nodes that optionally return rows, which I've simplified to return an empty schema that can be differentiated from the nil schema. We could make the distinction more explicit, also.
bump with perf here: [no-release-notes] insert perf bump dolthub/dolt#7894
ErrDatabaseNotFound
errorsWhen a database doesn't exist, MySQL returns error code 1049. This change adds a mapping to error code 1049 for
ErrDatabaseNotFound
errors, and updates our handler so thatComInitDB
messages will map errors to MySQL error codes.This is needed because tooling (e.g. Pomelo EntityFramework MySQL library) can rely on this error code in application logic.
Related to Pomelo Entity Framework connector is not able to recreate database. dolthub/dolt#7890
Closed Issues