Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql@5.7: disable #179297

Merged
merged 1 commit into from
Aug 1, 2024
Merged

mysql@5.7: disable #179297

merged 1 commit into from
Aug 1, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 1, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 1, 2024
@github-actions github-actions bot added legacy Relates to a versioned @ formula formula disabled Formula disabled labels Aug 1, 2024
@iMichka
Copy link
Member Author

iMichka commented Aug 1, 2024

It has been more than six months now.

There are still more than 6000 downloads / month but users have been warned for some time now.

@chenrui333 chenrui333 added this pull request to the merge queue Aug 1, 2024
@chenrui333
Copy link
Member

extended support ended 9 months ago

image

Merged via the queue into Homebrew:master with commit fd595fb Aug 1, 2024
17 checks passed
@iMichka iMichka deleted the mysql572 branch August 1, 2024 21:43
@mickeyreiss
Copy link

mickeyreiss commented Aug 6, 2024

@chenrui333 This was a breaking change for me. Given that Google Cloud Platform will continue to offer "extended support" for MySQL 5.7 through February 20281, I'd recommend reverting this change for now.

Footnotes

  1. https://cloud.google.com/sql/docs/mysql/db-versions#database-version-support

@iMichka
Copy link
Member Author

iMichka commented Aug 6, 2024

Hello. Yes it's a breaking change but the EOL timeline is known since a very long time, and we don't support EOL versions.

GCP might have extended support, but we would not have access to their source code? Not even sure we would be allowed to ship their patches and updates ...

@mickeyreiss
Copy link

@iMichka This is for local developer environments on MacOS who are creating applications that will use GCP's Cloud SQL MySQL 5.7 in production. In this use-case, they simply need a stable version of MySQL 5.7 - doesn't necessarily need to be the exact GCP fork.

@SMillerDev
Copy link
Member

In this use-case, they simply need a stable version of MySQL 5.7 - doesn't necessarily need to be the exact GCP fork.

And we need a supported version of the codebase. I agree it doesn't have to be the GCP version, but it must be a version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants