Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastpass-cli - add bash and fish completion scripts #24745

Closed
wants to merge 1 commit into from

Conversation

rderik
Copy link
Contributor

@rderik rderik commented Mar 2, 2018

Added to the formula the code to install the bash and fish completion
scripts.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Added to the formula the code to install the bash and fish completion
scripts.
@rderik rderik changed the title Add bash and fish completion scripts lastpass-cli - add bash and fish completion scripts Mar 2, 2018
@fxcoudert
Copy link
Member

Thanks @rderik for the pull request!

@fxcoudert fxcoudert closed this in fb732fe Mar 3, 2018
@rderik rderik deleted the lastpass-cli branch March 3, 2018 18:11
@BenjaminHCCarr
Copy link
Contributor

@fxcoudert @ilovezfs
I see that https://github.com/Homebrew/homebrew-core/blob/master/Formula/lastpass-cli.rb#L10 indicates a bottle rebuild: rebuild 1.
However, the formula is not automatically indicating that it needs to be updated by brew. In the old old old days we used to stick a {#ver}_1 on it to force the upgrade for users. is there no hook for rebottled builds? I had to manually brew reinstall lastpass-cli to get tab completion to install.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants