Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Json11 cpp library #30916

Closed
wants to merge 2 commits into from
Closed

[WIP] Json11 cpp library #30916

wants to merge 2 commits into from

Conversation

cdalvaro
Copy link
Contributor

@cdalvaro cdalvaro commented Aug 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source json11, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict json11 (after doing brew install json11)?

desc "Tiny JSON library for C++11"
homepage "https://github.com/dropbox/json11"
url "https://github.com/dropbox/json11.git", :revision => "ec4e45219af1d7cde3d58b49ed762376fccf1ace"
version "1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an officially tagged release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No... 😞

@fxcoudert
Copy link
Member

Hi @cdalvaro, thanks for the pull request. For us to consider including json11 as Homebrew formula, we need it to have stable, released versions with clear versioning scheme: https://docs.brew.sh/Acceptable-Formulae We are, for now, going to decline this pull request.

@fxcoudert fxcoudert closed this Aug 9, 2018
@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 9, 2018
@cdalvaro
Copy link
Contributor Author

cdalvaro commented Aug 9, 2018

Thank you for your comment @fxcoudert!

This library is built and maintained by Dropbox and their last commit was on Jun 21, 2017.
It is a really stable library.

The version is annotated in the CMakeLists.txt file. (project(json11 VERSION 1.0.0 LANGUAGES CXX)) although they don't have any release in their repository on GitHub neither tags.

Could be possible to accept this pull request despite the inconveniences?

@SMillerDev
Copy link
Member

From the acceptable formula requirements:

We don’t accept software without a tagged version because they regularly break due to upstream changes and we can’t provide bottles for them.

It really just breaks a part of homebrew if we would do that.
You could set it up in a personal tap though.

@cdalvaro cdalvaro changed the title Json11 cpp library [WIP] Json11 cpp library Aug 9, 2018
@cdalvaro
Copy link
Contributor Author

cdalvaro commented Aug 9, 2018

I'll try to get a tag or release version of the library.

Thank you for your attention @SMillerDev!

@cdalvaro
Copy link
Contributor Author

Finally there is a 1.0.0 version for the library.

Please @SMillerDev, could you reopen this PR in order to update the Homebrew formula?

Thank you very much!

@SMillerDev
Copy link
Member

I think it'd be better to make a new pull request.

@lock lock bot added the outdated PR was locked due to age label Sep 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants