-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Json11 cpp library #30916
[WIP] Json11 cpp library #30916
Conversation
desc "Tiny JSON library for C++11" | ||
homepage "https://github.com/dropbox/json11" | ||
url "https://github.com/dropbox/json11.git", :revision => "ec4e45219af1d7cde3d58b49ed762376fccf1ace" | ||
version "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an officially tagged release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No... 😞
Hi @cdalvaro, thanks for the pull request. For us to consider including json11 as Homebrew formula, we need it to have stable, released versions with clear versioning scheme: https://docs.brew.sh/Acceptable-Formulae We are, for now, going to decline this pull request. |
Thank you for your comment @fxcoudert! This library is built and maintained by Dropbox and their last commit was on Jun 21, 2017. The version is annotated in the CMakeLists.txt file. ( Could be possible to accept this pull request despite the inconveniences? |
From the acceptable formula requirements:
It really just breaks a part of homebrew if we would do that. |
I'll try to get a tag or release version of the library. Thank you for your attention @SMillerDev! |
Finally there is a 1.0.0 version for the library. Please @SMillerDev, could you reopen this PR in order to update the Homebrew formula? Thank you very much! |
I think it'd be better to make a new pull request. |
brew install --build-from-source json11
, where<formula>
is the name of the formula you're submitting?brew audit --strict json11
(after doingbrew install json11
)?