Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phantomjs: remove and migrate to cask #32538

Closed
wants to merge 3 commits into from
Closed

phantomjs: remove and migrate to cask #32538

wants to merge 3 commits into from

Conversation

bval
Copy link
Contributor

@bval bval commented Sep 28, 2018

This works in conjunction with Homebrew/homebrew-cask#52595 to migrate phantomjs over to a Cask. This is detailed in #32402.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fxcoudert
Copy link
Member

fxcoudert commented Sep 30, 2018

Error: Missing formulae should not have dependents!
asciinema2gif
casperjs

Both are simple javascript files that depend on phantomjs. Not sure what to do…

@fxcoudert fxcoudert added the maintainer feedback Additional maintainers' opinions may be needed label Sep 30, 2018
@fxcoudert fxcoudert mentioned this pull request Sep 30, 2018
9 tasks
@bval
Copy link
Contributor Author

bval commented Oct 1, 2018

asciinema2gif

asciinema2gif has 48 installs in 30 days, no commits in 2 years, and is simple enough to clone for the handful of people using it. Maybe safe to nuke?

casperjs

casperjs is unmaintained. It's also available via npm for those who still need it. Perhaps it's safe to remove from core? Current stats show 341 installs in 30 days, which is not nothing, but is relatively small.

If I get a 👍 I will update the PR to nuke those 2 formulae as well.

@fxcoudert
Copy link
Member

I don't see another way forward

@commitay
Copy link
Contributor

commitay commented Oct 3, 2018

Thanks @bval!

@commitay commitay closed this in cabc392 Oct 3, 2018
@bval bval deleted the migrate-phantomjs-to-cask branch October 4, 2018 18:12
@lock lock bot added the outdated PR was locked due to age label Nov 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants