Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: honour PYTHONEXECUTABLE if set #33969

Closed

Conversation

mjpieters
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Proposed fix for issue #33963: if the PYTHONEXECUTABLE environment variable is set, do not alter sys.executable.

@fxcoudert
Copy link
Member

@BrewTestBot test this please

@mjpieters
Copy link
Contributor Author

I'm confused by these build errors. None of those projects could be affected by the PYTHONEXECUTABLE change, since linking doesn't care about the sys.executable path.

@SMillerDev
Copy link
Member

@BrewTestBot test this please

@fxcoudert
Copy link
Member

Let's try it again: @BrewTestBot test this please

@fxcoudert
Copy link
Member

Thanks @mjpieters this is good to go.

@fxcoudert fxcoudert closed this in ea7f590 Nov 28, 2018
@lock lock bot added the outdated PR was locked due to age label Dec 28, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants