-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmuxinator 1.1.1 (new formula) #44567
Conversation
|
Formula/tmuxinator.rb
Outdated
sha256 "cc293578bca43ba5cf0d60c1355c6aa1da9d923a0acc274a47ceab03812a6ef4" | ||
head "https://github.com/tmuxinator/tmuxinator.git" | ||
|
||
depends_on "ruby" => "2.4.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not valid syntax. And as the bot pointed out, isn't this version available for all macOS targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the version requirement.
If i remove the hole depends_on "ruby" line, i get this error:
ERROR: Error installing tmuxinator-1.1.1.gem:
tmuxinator requires Ruby version >= 2.4.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SMillerDev can you explain me, what is wrong with this syntax?
I used this documentation for the depends_on part: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md#specifying-other-formulae-as-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're mixing :requirement => "version"
with "requirement" => :stage
which are very different things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining this. Now i understand the difference :-)
Is my change good, which makes the depends_on line valid?
I do not know, why i get the ruby version error if i skip this line.
If something else is missing, just let me know :-) |
Thanks @nexeck! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉 |
Tested with $ brew tap nexeck/homebrew-tmuxinator
==> Tapping nexeck/tmuxinator
Cloning into '/usr/local/Homebrew/Library/Taps/nexeck/homebrew-tmuxinator'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 5 (delta 0), reused 4 (delta 0), pack-reused 0
Unpacking objects: 100% (5/5), done.
Tapped 1 formula (30 files, 25.3KB).
$ brew install nexeck/homebrew-tmuxinator/tmuxinator
Updating Homebrew...
==> Installing tmuxinator from nexeck/tmuxinator
==> Downloading https://github.com/tmuxinator/tmuxinator/archive/v1.1.1.tar.gz
==> Downloading from https://codeload.github.com/tmuxinator/tmuxinator/tar.gz/v1.1.1
######################################################################## 100.0%
==> gem build tmuxinator.gemspec
==> gem install tmuxinator-1.1.1.gem
🍺 /usr/local/Cellar/tmuxinator/1.1.1: 1,388 files, 2.4MB, built in 14 seconds
$ tmuxinator version
tmuxinator 1.1.1 |
Thanks for your contribution! |
Closes Homebrew#44567. Signed-off-by: Rui Chen <rchen@meetup.com>
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?