Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmuxinator 1.1.1 (new formula) #44567

Closed
wants to merge 1 commit into from
Closed

Conversation

nexeck
Copy link
Contributor

@nexeck nexeck commented Sep 25, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot
Copy link
Member

  • Dependency 'ruby' may be unnecessary as it is provided by macOS; try to build this formula without it.

sha256 "cc293578bca43ba5cf0d60c1355c6aa1da9d923a0acc274a47ceab03812a6ef4"
head "https://github.com/tmuxinator/tmuxinator.git"

depends_on "ruby" => "2.4.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid syntax. And as the bot pointed out, isn't this version available for all macOS targets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the version requirement.
If i remove the hole depends_on "ruby" line, i get this error:

ERROR:  Error installing tmuxinator-1.1.1.gem:
tmuxinator requires Ruby version >= 2.4.6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev can you explain me, what is wrong with this syntax?
I used this documentation for the depends_on part: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md#specifying-other-formulae-as-dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're mixing :requirement => "version" with "requirement" => :stage which are very different things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining this. Now i understand the difference :-)

Is my change good, which makes the depends_on line valid?
I do not know, why i get the ruby version error if i skip this line.

@SMillerDev SMillerDev added the ruby Ruby use is a significant feature of the PR or issue label Sep 25, 2019
@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 26, 2019
@nexeck
Copy link
Contributor Author

nexeck commented Sep 27, 2019

If something else is missing, just let me know :-)

@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Sep 30, 2019
@SMillerDev
Copy link
Member

Thanks @nexeck! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@kenden
Copy link
Contributor

kenden commented Sep 30, 2019

Tested with

$ brew tap nexeck/homebrew-tmuxinator
==> Tapping nexeck/tmuxinator
Cloning into '/usr/local/Homebrew/Library/Taps/nexeck/homebrew-tmuxinator'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 5 (delta 0), reused 4 (delta 0), pack-reused 0
Unpacking objects: 100% (5/5), done.
Tapped 1 formula (30 files, 25.3KB).

$ brew install nexeck/homebrew-tmuxinator/tmuxinator
Updating Homebrew...
==> Installing tmuxinator from nexeck/tmuxinator
==> Downloading https://github.com/tmuxinator/tmuxinator/archive/v1.1.1.tar.gz
==> Downloading from https://codeload.github.com/tmuxinator/tmuxinator/tar.gz/v1.1.1
######################################################################## 100.0%
==> gem build tmuxinator.gemspec
==> gem install tmuxinator-1.1.1.gem
🍺  /usr/local/Cellar/tmuxinator/1.1.1: 1,388 files, 2.4MB, built in 14 seconds

$ tmuxinator version
tmuxinator 1.1.1

@chenrui333
Copy link
Member

Thanks for your contribution!

dickcav pushed a commit to dickcav/homebrew-core that referenced this pull request Oct 1, 2019
Closes Homebrew#44567.

Signed-off-by: Rui Chen <rchen@meetup.com>
@lock lock bot added the outdated PR was locked due to age label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants