Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang@17, riak: delete #46552

Closed
wants to merge 2 commits into from
Closed

erlang@17, riak: delete #46552

wants to merge 2 commits into from

Conversation

fxcoudert
Copy link
Member

See #46454

  • erlang@17 is not maintained anymore, we should remove it
  • erlang@17 does not support OpenSSL 1.1
  • it is needed only by riak, which is an old version
  • riak's build process is very fragile and several attempts to update it to newer versions have failed: riak 2.2.6 #34129 riak 2.9.0 #40075 riak 2.9.0p1 #40281

I am therefore suggesting to remove both. riak has 29 installs per month, erlang@17 has 64.

@fxcoudert fxcoudert changed the title Riak erlang@17, riak: delete Nov 9, 2019
@fxcoudert fxcoudert added maintainer feedback Additional maintainers' opinions may be needed marked for removal/rejection PR is probably going to be closed or formula deleted labels Nov 9, 2019
@fxcoudert fxcoudert closed this Nov 9, 2019
@fxcoudert fxcoudert deleted the riak branch November 9, 2019 16:25
@fxcoudert
Copy link
Member Author

Looks like I closed but forgot to actually merge 😕
Fixed in 8e8cdfb and 0b50e4f

chenrui333
chenrui333 reviewed Nov 16, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alebcay
Copy link
Member

alebcay commented Dec 7, 2019

Is relevant to #45514.

maxnordlund added a commit to maxnordlund/basho_docs that referenced this pull request Dec 15, 2019
@maxnordlund
Remove Homebrew install instuctions
d1dfe3f 
It has been removed [1][] due to Erlang 17 dependency, which only
supports EOL OpenSSL. The formulae also had numerous issues building,
which most likely needs upstream changes (aka here) before being
submitted again. An alternative would be an official tap [2][].

[1]: Homebrew/homebrew-core#46552
[2]: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
@maxnordlund maxnordlund mentioned this pull request Dec 15, 2019
Open
@lock lock bot added the outdated PR was locked due to age label Jan 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
maintainer feedback Additional maintainers' opinions may be needed marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fxcoudert @alebcay @chenrui333