Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black: remove resources declarations #47377

Closed

Conversation

chenrui333
Copy link
Member

Remove resource declarations for the formula (would be easier for bump the version in the future)

@Moisan Moisan added the python Python use is a significant feature of the PR or issue label Dec 2, 2019
@SMillerDev
Copy link
Member

Do we have a lockfile from upstream verifying hashes with strictly pinned versions?

@chenrui333
Copy link
Member Author

@SMillerDev
Copy link
Member

That isn't used in the implementation you're proposing though. So ever install would potentially be different.

@Moisan
Copy link
Member

Moisan commented Dec 3, 2019

I spent a moment trying to get pipenv and piplock to work with this formula. It doesn't work so far but here is my best attempt:

    ENV["WORKON_HOME"] = libexec
    system "pipenv", "install", "--ignore-pipfile"

--ignore-pipfile forces to use the piplock file.
pipenv doesn't have an option (yet) to build the in a precise directory its virtual environment. The nearest thing is WORKON_HOME which is the directory in which it will create a folder named by using a hash unknown before execution. We can find back the location of the environment with

pyenv shell
pyenv --where

I was hoping that once we get the exact location of the virtualenv, we could do something like bin.install_symlink "#{libexec}/#{the_venv_folder}/bin/black" => "black" to symlink the binary like we usually do.

@Moisan Moisan added do not merge help wanted Task(s) needing PRs from the community or maintainers labels Dec 4, 2019
@Moisan
Copy link
Member

Moisan commented Dec 4, 2019

Tried again but couldn't get it to work, anyone else is welcome to give it a try.

@chenrui333
Copy link
Member Author

With this recipe repo as rescue, I am good for closing the PR now. :)
https://github.com/dawidd6/homebrew-update-pypi-resources

Thanks @Moisan for your efforts, really appreciate it!!

@chenrui333 chenrui333 closed this Dec 10, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@chenrui333 chenrui333 deleted the black-remove-python-resources branch December 18, 2022 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants