Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manpage/completion installs for bat formula #52058

Closed
wants to merge 3 commits into from
Closed

Fix manpage/completion installs for bat formula #52058

wants to merge 3 commits into from

Conversation

jeffbyrnes
Copy link
Contributor

@jeffbyrnes jeffbyrnes commented Mar 23, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This picks up from where #52022 landed, and adjusts things to play more nicely.

This uses the manpage & fish completion that the install generates itself, instead of trying to hack a way to get the right files made.

This uses the manpage & fish completion that the install generats
itself, instead of trying to hack a way to get the right files made.
Formula/bat.rb Outdated Show resolved Hide resolved
Formula/bat.rb Outdated Show resolved Hide resolved
Co-Authored-By: Alexander Bayandin <a.bayandin@gmail.com>
@chenrui333 chenrui333 mentioned this pull request Mar 26, 2020
@bayandin bayandin self-assigned this Apr 9, 2020
@bayandin bayandin closed this in 23ee2ae Apr 9, 2020
@bayandin
Copy link
Member

bayandin commented Apr 9, 2020

Thanks @jeffbyrnes for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@jeffbyrnes jeffbyrnes deleted the fix-bat-formula-manpage-completion-installs branch April 9, 2020 16:45
@bayandin bayandin removed their assignment Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants