Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lychee 0.7.0 (new formula) #70216

Closed
wants to merge 1 commit into from
Closed

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Feb 2, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Feb 2, 2021
@carlocab
Copy link
Member

carlocab commented Feb 2, 2021

  error: unknown target triple 'unknown-apple-macosx11.0.0', please use -triple or -arch

Not compatible with ARM yet, it seems.

@alebcay
Copy link
Member Author

alebcay commented Feb 2, 2021

Upstream seems to think that the issue is probably similar to getting exa to build (lycheeverse/lychee#59 (comment)). The issue is specifically with the ring crate.

@carlocab
Copy link
Member

carlocab commented Feb 2, 2021

It's possible:

error: failed to run custom build command for `ring v0.16.15`

except that ring is at 0.16.20. The solution may be as simple as updating their Cargo.lock file and cutting a new release with it.

@chenrui333 chenrui333 added the 11-arm64 Big Sur arm64 is specifically affected label Feb 20, 2021
@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Mar 14, 2021
carlocab
carlocab previously approved these changes Mar 14, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not opposed to this formula even if it doesn't build on ARM. I imagine it will eventually anyway.

Rebased, though, to make sure it builds against the current version of Rust.

@carlocab carlocab added in progress Stale bot should stay away and removed stale No recent activity labels Mar 14, 2021
@alebcay
Copy link
Member Author

alebcay commented Mar 14, 2021

Just FYI, they're waiting on some of their own dependencies for Big Sur support: lycheeverse/lychee#59 (comment).

@carlocab
Copy link
Member

If you prefer to wait that's fine with me too. I just thought you were waiting for someone else to approve this before you merged.

@alebcay
Copy link
Member Author

alebcay commented Mar 14, 2021

I can rebase it anyways; I've kind of just left this open here for tracking purposes up until now.

@alebcay alebcay changed the title lychee 0.5.0 (new formula) lychee 0.7.0 (new formula) Apr 22, 2021
@alebcay alebcay removed 11-arm64 Big Sur arm64 is specifically affected in progress Stale bot should stay away labels Apr 23, 2021
@alebcay
Copy link
Member Author

alebcay commented Apr 23, 2021

Looks like all checks are passing now 🎉

@BrewTestBot
Copy link
Member

:shipit: @nandahkrishna has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants