rbenv 1.2.0

[mislav]

The workaround was meant to hardcode the path to rbenv executable to prevent rbenv itself detecting the path to its executable and finding it under /usr/local/Cellar/rbenv/VERSION/libexec/..., which is a path we cannot rely on in the long term due to Homebrew's automatic cleanup.

However, the workaround is brittle:

• It's currently failing CI jobs, even those unrelated to rbenv;
• If the hardcoded path that's the result of opt_bin/"rbenv" makes it into a bottle, it's not guaranteed to match the opt/bin path on someone else's system. Such bottles would not be portable.

Reverts #75996 /cc @steinybot

I might try to come up with a permanent solution for this from within rbenv itself.

[carlocab]

This isn't necessary -- the failure is because the test block assumes that the bottles have been built with the workaround, but they haven't.

[carlocab]

We can just comment this out for now and CI jobs will pass.

[mislav]

@carlocab See my comment above about bottles. Let's say that we rebuild the rbenv bottle—wouldn't it be dangerous to hardcode the local opt/bin directory in a bottle? What if that bottle gets restored on a system with a different Homebrew prefix?

[carlocab]

What if that bottle gets restored on a system with a different Homebrew prefix?

Keg relocation will take care of that. opt_bin isn't actually recorded as /usr/local/opt/rbenv/bin in the bottle. Instead, it is replaced with @HOMEBREW_PREFIX@/opt/rbenv/bin upon bottling, with @HOMEBREW_PREFIX@ substituted for the correct value upon pouring.

See https://github.com/Homebrew/brew/blob/3.2.13/Library/Homebrew/keg_relocate.rb.

[mislav]

@carlocab Ah, thanks for explaining!

Then this doesn't have to be reverted. As for the failing test; could we just keep the original test and bump up the revision of the formula to force re-bottling?

[Bo98]

As for the failing test; could we just keep the original test and bump up the revision of the formula to force re-bottling?

Yeah this should have received new bottles IMO.

I get the argument that the issue will only happen on the next version bump, but equally it is affecting people setting up their environments now for when the bump happens in the future so we're just increasing the number of people affected by delaying it.

[mislav]

I've modified this PR to upgrade to rbenv 1.2.0 which isn't susceptible to the rehash problem across Homebrew upgrades. rbenv/rbenv#1350

Please re-review!

[carlocab]

Thanks @mislav!

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[carlocab]

Oops. Forgot to remove the CI-no-bottles label. Should be fixed now.