Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: Disable universal builds. #8660

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

woodruffw
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Previously, universal builds had removed several modules from i386/ppc
targets to get the build to succeed. This is becoming increasingly
unsustainable as i386 and PPC age and are no longer supported.

See #7852.

Previously, universal builds had removed several modules from i386/ppc
targets to get the build to succeed. This is becoming increasingly
unsustainable as i386 and PPC age and are no longer supported.

See Homebrew#7852.
@woodruffw
Copy link
Member Author

ncmpcpp's test is failing on El Cap and Sierra. Not sure if that's a side effect of boost changing, since it's just a --version test and ncmpcpp isn't built as a universal binary...

@MikeMcQuaid
Copy link
Member

If it doesn't fail for you locally before or after the PR I'd say just :shipit:.

@woodruffw woodruffw merged commit 06a77a2 into Homebrew:master Jan 16, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants