libpgm 5.3.128

[branchvincent]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

#93940

This needs a test

[danielnachun]

It looks like this package contains x86 assembly code, which is unsurprising given that it is designed to interface at a low level with hardware. So I think this needs depends_on arch: :x86_64 as it is non-trivial for this formula to natively support ARM64.

[danielnachun]

For the test I'd recommend taking some C code from the testing folder here: https://github.com/steve-o/openpgm/tree/master/openpgm/pgm/test, remove all the ifdef sections for WIN32, and then have it compile to a very small application that will include the libpgm headers, and dynamically link to the libpgm shared libraries. This type of test is usually sufficient to catch major issues with the package, without requiring too much code.

[SMillerDev]

Should have a test before merging

[branchvincent]

Fumbled my way to a test, let me know if anything looks off

[SMillerDev]

Thanks @branchvincent ! Without your contributions it'd be impossible to keep homebrew going. You can feel good knowing that you've made the world a lot better for homebrew users around the world! 👍 🎉

[BrewTestBot]

🤖 A scheduled task has triggered a merge.