-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
depends_on "little-cms" => "with-python" | ||
depends_on "pyqt" | ||
depends_on "homebrew/python/pillow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t allow core formulae to depend on tap ones. If this is a mandatory requirement we must move this formula to the Python tap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine to vendor. We do so in mitmproxy
without any obviously horrific problems. Possible the instruction to use pip
in this formula previously is a relatively old relic.
how do i make the install block work ? |
Check out |
From Cookbook:
Will test this out |
@DomT4 this is also a little out of my comfort zone. Would you be willing to assist ? |
ENV["PYTHONPATH"] = libexec/"vendor/lib/python2.7/site-packages" | ||
|
||
resource("Pillow").stage | ||
system "python", *Language::Python.setup_install_args(libexec/"vendor") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap this line in a block and give it to the line above; it should look like this:
resource("Pillow").stage do
system "python", *Language::Python.setup_install_args(libexec/"vendor")
end
Resource#stage
takes either a directory or a block. In the former case it’ll unpack (read: uncompress) in it. In the latter it’ll create a temporary directory, cd
and unpack in it, call the block, then cd
back to where it was previously. Here we’re using a block so that unpacking the resource doesn’t mess with the buildpath.
This is what ansible.rb
does except that it uses resources
to access all resources instead of retrieving each resource with its name using resource("<name>")
.
Ping? |
Help needed on this... please |
Closing this due to inactivity/lack of response. If you'd still like to pursue this, feel free to respond to the previous comments/questions and re-open on the new |
as per #45667