Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

swatchbooker w/o pip install pillow #45682

Closed
wants to merge 2 commits into from
Closed

swatchbooker w/o pip install pillow #45682

wants to merge 2 commits into from

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 4, 2015

as per #45667

depends_on "little-cms" => "with-python"
depends_on "pyqt"
depends_on "homebrew/python/pillow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t allow core formulae to depend on tap ones. If this is a mandatory requirement we must move this formula to the Python tap.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine to vendor. We do so in mitmproxy without any obviously horrific problems. Possible the instruction to use pip in this formula previously is a relatively old relic.

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 4, 2015

how do i make the install block work ?

@MikeMcQuaid
Copy link
Member

Check out ansible.rb, that should be helpful.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 22, 2016

From Cookbook:

homebrew-pypi-poet can help you generate resource stanzas for the dependencies of your Python application

Will test this out

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 23, 2016

@DomT4 this is also a little out of my comfort zone. Would you be willing to assist ?

ENV["PYTHONPATH"] = libexec/"vendor/lib/python2.7/site-packages"

resource("Pillow").stage
system "python", *Language::Python.setup_install_args(libexec/"vendor")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap this line in a block and give it to the line above; it should look like this:

resource("Pillow").stage do
  system "python", *Language::Python.setup_install_args(libexec/"vendor")
end

Resource#stage takes either a directory or a block. In the former case it’ll unpack (read: uncompress) in it. In the latter it’ll create a temporary directory, cd and unpack in it, call the block, then cd back to where it was previously. Here we’re using a block so that unpacking the resource doesn’t mess with the buildpath.

This is what ansible.rb does except that it uses resources to access all resources instead of retrieving each resource with its name using resource("<name>").

@bfontaine
Copy link
Contributor

Ping?

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 10, 2016

Help needed on this... please

@ghost ghost removed the needs response label Apr 10, 2016
@ilovezfs
Copy link
Contributor

@apjanke apjanke modified the milestone: Clear out Legacy May 3, 2016
@apjanke
Copy link
Contributor

apjanke commented May 3, 2016

Closing this due to inactivity/lack of response. If you'd still like to pursue this, feel free to respond to the previous comments/questions and re-open on the new homebrew/core repo.

@apjanke apjanke closed this May 3, 2016
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants