-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(2494): Incidents: Add the ability to edit incident details #2604
Conversation
Merge HospitalRun/hospitalrun-frontend to riiniii/hospitalrun-frontend
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/4dXSAb5V13DeCW3Q3VAWgfainYaU |
Renee Huang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hi @riiniii. Is this a WIP PR? |
yes, it is. will add WIP next time! |
…ResolveIncident to useUpdateIncident, and include previously merged page (Visitform)
…end into fix/2494
@tehkapa some of the tests are not passing due to enzyme module not found on git... do you know how this error can be fixed? assuming this has to do w github and not mines as its a test running remotely otherwise this is ready for review |
@riiniii I've tested locally and it doesn't work on my Mac either. Could you please show me a screenshot of the tests that run on your PC? |
@riiniii Hi, can you sign the cla? Also, regarding the test failing, it might be that you are in a stale branch that hasn't completed the conversion to RTL. Perhaps you could run |
ok! shall try, ty! |
@jameszheng405 closing this pr in favor of #2689 where i cherry picked the relevant commits from here + tests pass. |
fix #2494
Fixes #2494.
Changes proposed in this pull request:
1a. department
1b. category
1c. category item
1d. description
1e. incident reported to (*) - (to-do, need more info on whether this maps to another user or is just string field)
1f. patient impacted
to do: