Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add secondary directory structure; add tests for conductivity #20

Merged
merged 58 commits into from
Nov 4, 2023

Conversation

htz1992213
Copy link
Collaborator

@htz1992213 htz1992213 commented Jul 19, 2022

Summary

Add secondary directory structure; add tests for conductivity

  • Added secondary directory structure for core and forcefield
  • Added initial tests for conductivity

TODO (if any)

  • Add more secondary directory structure
  • Add more tests for conductivity

Checklist

Work-in-progress pull requests are encouraged. Please put [WIP]
in the pull request title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style. The easiest way to handle this
    is to run the following in the correct sequence on your local machine. Start with running
    black on your new code. This will automatically reformat
    your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by
    flake8.
  • Docstrings have been added in the Google docstring format.
    Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy to type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

@htz1992213
Copy link
Collaborator Author

Most of the targets have been achieved. Use separate PR to complement tests.

@htz1992213 htz1992213 merged commit 873f22b into HouGroup:main Nov 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant