Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #6

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Improvements #6

merged 5 commits into from
Sep 28, 2023

Conversation

wbenny
Copy link

@wbenny wbenny commented Sep 27, 2023

Hi there!
I've stumbled upon your nifty library and it's been real help.

However, I found that I had to do few changes for my use-case.
I feel those changes are general enough that they can be useful for everyone.

@HsuJv
Copy link
Owner

HsuJv commented Sep 27, 2023

Hi @wbenny

Looks great!!
But would you mind helping fix the related ci-report before it is merged?
Thanks in advance for your contribution

BRs.

@wbenny
Copy link
Author

wbenny commented Sep 27, 2023

My bad, looks like I've commited files before actualy saving them in the editor. Let's see if it passes now :)

@wbenny
Copy link
Author

wbenny commented Sep 27, 2023

Huh, looks like I need to do more fixes :)

@HsuJv
Copy link
Owner

HsuJv commented Sep 27, 2023

Well, it seems some example code still using anyhow, it's better to add this crate in 'dev-depencies'
Also an old declaration of my function breaks the clippy test, can you help remove it so that this PR can be processed with CI happy?

@HsuJv
Copy link
Owner

HsuJv commented Sep 27, 2023

For the wasm32 one, I can check it later and provide some help. But if you have any ideas, please feel free to patch it. I've changed the privilege of CI-running so that you can run it yourself.
Besides, you can also use cargo build --target wasm32-unknown-unknown --verbose --all-features to test the wasm32 build locally.

BRs

@wbenny
Copy link
Author

wbenny commented Sep 27, 2023

I've managed to fix everything mentioned and force-pushed over the last commit. However, it looks like the CI workflow didn't trigger.

@HsuJv
Copy link
Owner

HsuJv commented Sep 27, 2023

Cheers! Happy to hear that.

Do you need a new release of this? If so I will process it ASAP.

@HsuJv HsuJv merged commit 96e7392 into HsuJv:main Sep 28, 2023
6 checks passed
@wbenny
Copy link
Author

wbenny commented Sep 28, 2023

New release would be perfect :)

Thank you!

@HsuJv
Copy link
Owner

HsuJv commented Sep 28, 2023

Hi there,
I've just verified that this PR not breaking the current work on both Ubuntu 20.04 and WASM for the browser.
And publish version 0.5.0 as there are API changes.
BRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants