Use HostAndPort#getHostText instead of HostAndPort#getHost #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @stevegutz , I'll try this out in staging/qa before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostAndPost#getHostreplacedHostAndPort#getHostTextin Guava 20 andHostAndPort#getHostTextwas removed in Guava 22. This PR should have no semantic effect on your code. Java docI had to upgrade to Guava 20.0 to get the new functionality, if I go to 21 tests fail because curator is not compatible with that version. This codepath should never be hit outside of
BaragonAgentService, so don't rush to merge this if you're worried about the version change.@ssalinas @baconmania @darcatron