Add filter to interpret a string early #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamrharwood
requested review from
mattcoley,
bkrainer,
phalaphone and
jasmith-hs
mattcoley
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
I don't think this is more dangerous than the regular nested interpretation stuff but wanted to get @jasmith-hs thoughts on this as well
jasmith-hs
approved these changes
Dec 11, 2020
| input = @JinjavaParam(value = "s", desc = "String to render", required = true), | ||
| snippets = { | ||
| @JinjavaSnippet( | ||
| code = "{{ \"{% if my_val %}} Hello {% else %} world {% endif %}\"|render }}" |
There was a problem hiding this comment.
There's an extra } after {% if my_val %}
|
|
||
| @Test | ||
| public void itWritesObjectAsString() { | ||
| String stringToRender = "{% if null %}}Hello{% else %}world{% endif %}"; |
There was a problem hiding this comment.
There's an extra } here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
RenderFilterwhich can be used to interpret a template string early.For instance, the following:
would output
World. However, you could use the result of the filter in other filters, like so:which would output
world.This is useful in cases where a function or other construct results in an expression that must be interpreted before applying other filters / transformations.
I'm open to naming this something different if people don't like
render.