Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jinjava, we parse something surrounded with parentheses either as an
AstTuple
or anAstNested
. When there is a single element inside the parentheses, we'll parse it asAstNested
, otherwise it will become anAstTuple
.This check was done by seeing if there are any commas before the first
)
. However, this is inadequate for two reasons:#{(range(0,1))}
. Clearly this shouldn't be parsed as a tuple, but this bug caused it to be.#{((1),2)}
. Clearly this should be parsed as a tuple, but the bug causes it to be parsed as anAstNested
The fix here simply maintains a counter of depth into parentheses or brackets, and only checks for the existence of a comma symbol when at 0 depth. We don't need to worry about matching
(
to)
and[
to]
here because if they are mismatched, the correct parsing exception will get thrown down the line anyway.