Make LazyExpression memoization disable-able #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
reviewed
May 27, 2021
src/main/java/com/hubspot/jinjava/interpret/LazyExpression.java
Outdated
Show resolved
Hide resolved
boulter
reviewed
May 27, 2021
src/main/java/com/hubspot/jinjava/interpret/LazyExpression.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack Smith <72623970+jasmith-hs@users.noreply.github.com>
boulter
reviewed
May 27, 2021
src/main/java/com/hubspot/jinjava/interpret/LazyExpression.java
Outdated
Show resolved
Hide resolved
boulter
approved these changes
May 27, 2021
src/test/java/com/hubspot/jinjava/interpret/LazyExpressionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/hubspot/jinjava/interpret/LazyExpressionTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Boulter <jeff@boulter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional factory
of(Supplier, String, Memoization)which allows for memoization ofLazyExpressionobjects to be explicitly enabled or disabled.The original factory
of(Supplier, String)retains the original, memoized behavior.