Add UMD support, fixes #10 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The AMD and Common JS bits of code should have jquery as a dependency. Also, I think it makes sense to have vex dialog depend on vex too. |
|
Thanks @timmfin, any chance you can make those changes? I don't really know enough about browserify to do the jquery bit for commonjs (add a require?), and I don't know much about how AMD defines it's deps. |
Closed
|
Sure, I can do this. @adamschwartz do you have a buildscript for this project? If so, could you check it in so I could use it to build my changes? |
Also fixed vex.dialog so that it would work under AMD (it couldn't use `vex.dialog`, it needed to refer to `dialog` instead).
* master: Updating combined grunted Grunt vex dialog Fix grunt paths Add package json, gruntfile, and node_modules to gitignore Component version to 1.2.0 Conflicts: js/vex.dialog.js js/vex.js
* origin/master: Compile vex.combined.min.js with grunt @tfinley
* origin/master: Grunt once more with feeling! Conflicts: js/vex.combined.min.js js/vex.dialog.min.js js/vex.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.