Signing modal issues #5581
Merged
Signing modal issues #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keianhzo I have tested this on hubs.mozilla.com and was not able to reproduce any of the related issues. |
|
I can no longer reproduce this issue on the latest Hubs Cloud build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4810
We set the modals
onClosecallback to eitheronContinueAfterSignInorcloseDialogdepending if the dialog needs to execute an action after signing or not but we never resetonContinueAfterSignIn. This means that if after showing a dialog that requires an action we show one that doesn't, the second one won't close as it will keep on calling the previousonContinueAfterSignIncallback.This PR reverts a previous patch, resets the
onContinueAfterSignIncallback after it's been called and fixes some component property types that are throwing warnings.@SV-AndreiC I think it's worth revisiting these already closed issues. I've tested them but just in case:
#4695
#4367
#3886
#4810