Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default theme to fix the rest button #5590

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Jul 15, 2022

I've seen that this is broken while working on another PR.

We set the default theme to undefined but that breaks the reset button. This PR sets the theme default to the default theme or the first one in case none has been tagged as default.

Copy link
Contributor

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo keianhzo merged commit 3afe8a4 into master Jul 15, 2022
@keianhzo keianhzo deleted the default-theme-fix branch July 15, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants