Convert networking system to typescript #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominick D'Aniello <netpro2k@gmail.com>
netpro2k
reviewed
Nov 22, 2022
| @@ -36,11 +42,25 @@ export function takeOwnership(world, eid) { | |||
| } | |||
| } | |||
|
|
|||
| const createMessageDatas = new Map(); | |||
| type EntityID = number; | |||
There was a problem hiding this comment.
Might be nice to start using this universally just for ease of reading. Tradeoff is tricking ourselves into thinking its something special and making EntityID specific things when we are actually just doing number stuff.
There was a problem hiding this comment.
It feels "correct" to call them EntityIDs because (even though this isn't enforced), EntityIDs are a narrower type than numbers: They are (supposed to be) uints between 0 and MAX_ENTITY_COUNT.
johnshaughnessy
deleted the
feature/convert-networking-system-to-typescript
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert networking system to typescript in preparation for future changes