-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate billboard to bit-ecs #5901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Made a few small comments.
Biggest one would be getting rid of use of frame scheduler, I suspect we won't need that anymore going forward but maybe we will want some utility functions for doing something similar if we find ourselves writing the same code in many systems.
Also lets make sure we preserver that TODO, billboard as it is kind of stopped making sense since we now have many potential cameras in the scene. (Maybe it just needs to be renamed face-player
. I would definitely like to also explore something more akin to how other engines handle billboarding and have it be more of a rendering concept, sitting at the same level as something like Mesh. That allows us to do the billboarding as part of the vertex shader.
Thanks for the feedback, it helped a lot. Regarding the vertex shader approach, definitely worth exploring specially if I have addressed most of the feedback except from:
|
This PR migrates the billboard component and also makes some choices that I'd like comments on:
inflatorWrapper
function to wrap a component inflator. I assume we will need to do this quite a lot for some components so it might be useful to have a convenience function for it