Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity state persistence #5904

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Entity state persistence #5904

merged 6 commits into from
Feb 7, 2023

Conversation

johnshaughnessy
Copy link
Contributor

@johnshaughnessy johnshaughnessy commented Jan 20, 2023 •
edited
Loading

Use the new persistence APIs described in: Hubs-Foundation/reticulum#662

The calls are behind an entity_state_api query string parameter, so that we can safely ship the client changes before the backend API is live. The client has many more changes than reticulum, so it would be good to merge this PR sooner rather than later and avoid merge conflicts.

While building this API, we also realized that we should not be sending creator information in update messages. Instead, the creator is set exclusively by reticulum (via the fromClientId on an nn message, or as a CreatorChange queued in response to entity_state_created or entity_state_deleted).

@johnshaughnessy johnshaughnessy mentioned this pull request Jan 20, 2023
Merged
@johnshaughnessy johnshaughnessy changed the base branch from master to post-pdf-tweaks January 20, 2023 23:13
@johnshaughnessy johnshaughnessy force-pushed the post-pdf-tweaks branch 2 times, most recently from 08101dd to 9474101 Compare January 28, 2023 23:12
@johnshaughnessy johnshaughnessy force-pushed the feature/message-store branch 2 times, most recently from 6c87080 to 04cf747 Compare January 28, 2023 23:29
@johnshaughnessy johnshaughnessy marked this pull request as ready for review January 31, 2023 07:31
@johnshaughnessy johnshaughnessy changed the title WIP New way to save entity states Persistent entity state Jan 31, 2023
@johnshaughnessy johnshaughnessy changed the title Persistent entity state Entity state persistence Jan 31, 2023
@johnshaughnessy johnshaughnessy changed the base branch from post-pdf-tweaks to master January 31, 2023 17:30
@johnshaughnessy johnshaughnessy force-pushed the feature/message-store branch 2 times, most recently from ef26cd5 to 4c13ed7 Compare February 3, 2023 19:51
@johnshaughnessy johnshaughnessy merged commit 0bac051 into master Feb 7, 2023
@johnshaughnessy johnshaughnessy deleted the feature/message-store branch February 7, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnshaughnessy