Fix type issues for simple-water and particle-emitter #5952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that I've seen in earlier code of mine. I think the reason the bug was introduced was that after adding support for the glTF inflator I wanted the component to also work for JSX entities and I changed the component parameters data to array obviously breaking the glTF support. I've fixed that.
I've also limited the
simple-water
andparticle-emitter
inflators support only to glTF as I've seen that for this type of components we are not really adding support for JSX (seeUVScroll
component) and adding support for JSX would require adding another inflator which I'm not sure if it's worth i. Is this assumption correct or we want parity?