Add ModelLoader to bitecs #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
Feb 21, 2023
netpro2k
reviewed
Mar 7, 2023
| } | ||
|
|
||
| export function inflateModelLoader(world: HubsWorld, eid: number, params: ModelLoaderParams) { | ||
| inflateMediaLoader(world, eid, { |
There was a problem hiding this comment.
Based on the old defaults https://github.com/mozilla/hubs/blob/aaa4584a822545a8ea998c3c14edc62078fb542b/src/gltf-component-mappings.js#L267-L275 I think resize and recenter should be true. Technically models like this had an object menu too, though it was a restricted one with only "open link", "refrresh" , "inspect', and "focus" - I don't think its particularly important to preserve that.
This commit adds ModelLoader inflator for glTF model component.
takahirox
force-pushed
the
BitECSModelLoader
branch
from
a1f41e7
to
39a65cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ModelLoader inflator for glTF model component.