Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Media loading HTML support to bitecs #5977

Merged
merged 1 commit into from
May 12, 2023
Merged

Add Media loading HTML support to bitecs #5977

merged 1 commit into from
May 12, 2023

Conversation

takahirox
Copy link
Contributor

This PR adds media loading HTML support to bitecs.

"Open Link" support requires #5976 so draft now.

image

@takahirox takahirox mentioned this pull request Mar 3, 2023
Open
50 tasks
@takahirox takahirox marked this pull request as ready for review March 17, 2023 05:18
@takahirox
Copy link
Contributor Author

Switched to "ready for review" because #5976 has been merged.

@keianhzo keianhzo self-requested a review May 11, 2023 08:40
keianhzo
keianhzo reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I expected the Link hover menu to work after #5976 has landed. Is it missing?

@takahirox
Copy link
Contributor Author

I thought it would work but, right, it doesn't... Let me investigate.

@takahirox
Copy link
Contributor Author

I noticed that I had forgotten to add link inflator key to EntityDef. But if I add it, the object won't move by cursor. RemoteHoverTarget component seems to be the cause.

So I didn't add link, instead I added a TODO comment for it for now. I hope we can investigate and resolve the root issue in the follow up PRs.

@takahirox takahirox merged commit 0434aea into master May 12, 2023
@takahirox takahirox deleted the BitECSHTMLLoader branch May 12, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keianhzo keianhzo keianhzo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahirox @keianhzo