Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most audio buttons may not work anymore #138

Closed
HugoFara opened this issue Jul 23, 2023 · 3 comments · Fixed by #191
Closed

Most audio buttons may not work anymore #138

HugoFara opened this issue Jul 23, 2023 · 3 comments · Fixed by #191
Labels
bug Something isn't working ui Any problem related to the User Interface

Comments

@HugoFara
Copy link
Owner

No JavaScript error was thrown, needs a bit of investigation.

By the way, some of the audio features may not be necessary.
@HugoFara HugoFara added bug Something isn't working ui Any problem related to the User Interface labels Jul 23, 2023
@HugoFara
Copy link
Owner Author

After investigation, the issue is not so bad. Only the "go faster" and "go slower" feature was broken. Two JavaScript functions, click_slower and click_faster were redefined in src/js/audio_controller.js, leading to the broken feature.

This will be patched by changing the names of the functions. Renaming yet patch only as are they are not in the documented interface anyway.

@HugoFara HugoFara reopened this Dec 27, 2023
@HugoFara
Copy link
Owner Author

The replay button is still not working, as the "file end event" ($.jPlayer.event.ended) is no longer triggered. It may be related to the fact that jPlayer is not compatible with jQuery 3.

A modern rewrite using the HTML audio element seems necessary.

ProgramComputer added a commit to ProgramComputer/lwt that referenced this issue Dec 29, 2023
@ProgramComputer @HugoFara
Patch 6 (#2)
f80e26d 
* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>
ProgramComputer added a commit to ProgramComputer/lwt that referenced this issue Dec 30, 2023
@ProgramComputer @HugoFara
Patch 6 (#3)
23db881 
* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* future php platforms

* less vulnerabilities for larger size

* Lwt is accessed at /lwt/

https://hugofara.github.io/lwt/docs/info.html#install

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>
ProgramComputer added a commit to ProgramComputer/lwt that referenced this issue Dec 30, 2023
@ProgramComputer @HugoFara
Patch 6 (#4)
9f4b863 
* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* future php platforms

* less vulnerabilities for larger size

* Lwt is accessed at /lwt/

https://hugofara.github.io/lwt/docs/info.html#install

* Update Dockerfile

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>
ProgramComputer added a commit to ProgramComputer/lwt that referenced this issue Dec 30, 2023
@ProgramComputer @HugoFara
Patch 6 (#5)
76311e3 
* Patch 6 (#2)

* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* future php platforms

* less vulnerabilities for larger size

* Lwt is accessed at /lwt/

https://hugofara.github.io/lwt/docs/info.html#install

* Update Dockerfile

* Update docker-image.yml

* Update Dockerfile

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>
ProgramComputer added a commit to ProgramComputer/lwt that referenced this issue Dec 31, 2023
@ProgramComputer @HugoFara
Patch 6 (#6)
e01ec1e 
* Code clean-up with the audio controller.
Remove the unitended declaration of global variables.

* Refactor audio_controller in  object  namespace style.
Backward compatibility is kept.

* Fixes HugoFara#138: changing audio speed was partially broken.

* Replaces calls to global audio functions by the new object.
Removes the undocumented audio functions.

* Avoid unnecessary function return type.

* Fixes "text_id is unkown" on text opening.

* Fixes warning on step 2 of feed wizard (related to HugoFara#129)

* Reorders functions to be in logical declaration order.

* Code cleaning.

* Refactoring jq_feedwizard as object namespace.

* Synctactic sugar on jq_feedwizard.js.

* Adds an helper object to avoid one-line JS.

* Prettyfies JS code.

* Isolates JS code in feed wizard step 3.

* Use json_encode to avoid PHP incursion in JS code.
Code prettyfying.

* Beautify JS and avoid calls to deprecated functions.

* Fixes JS errors on feeds: xPath was not set, and it was sometimes leave step 2.

* Beautifies demo DB as the users has the right to see what they install.

* Fix: the demo database was unreadable since last commit.
restore_file is much better at parsing SQL.

* Stop reading demo on errors, syntactic suger.

* Better detection of file end not read.

* Changes WoStatusChange to a value that doesn't need configuration change (HugoFara#78).

* Implementes HugoFara#148: removes dead feeds from demo database.

* Fixes a bug introduced in a previous commit.
Signalled by  @ProgramComputer.

* Fixes HugoFara#151: click delete on a language deletes the language.

* Multi-image docker

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* Update docker-image.yml

* future php platforms

* less vulnerabilities for larger size

* Lwt is accessed at /lwt/

https://hugofara.github.io/lwt/docs/info.html#install

* Update Dockerfile

* Update docker-image.yml

* Update Dockerfile

* Update docker-image.yml

---------

Co-authored-by: HugoFara <hugo.farajallah@protonmail.com>
@ProgramComputer ProgramComputer mentioned this issue Jan 10, 2024
Merged
@HugoFara HugoFara linked a pull request Jan 11, 2024 that will close this issue
[BUG] Jplayer buttons #191
Merged
@HugoFara
Copy link
Owner Author

HugoFara commented Apr 1, 2024

This was fixed with the help of @ProgramComputer through #191, and release in 2.10.0, happy listening!

@HugoFara HugoFara closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui Any problem related to the User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Jplayer buttons ProgramComputer/lwt
1 participant
@HugoFara