New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS highlights many places during multi-word term creation. #69
Comments
edit_mword.php gens bad javascript at some point:
|
(I can't follow what the intent is with the some parts of the code, especially I added a small logging function to a test branch in my fork, branch name
Call stack
In
(In this case, here's the data:) db dump
... and then in Trace
This dict is then passed to ... and then this eventually makes it to |
new_expression_interactable2 is called once and declares title again. https://github.com/ProgramComputer/lwt/blob/05afb1b8089e5ad6a60ded87e547a49cebd2d7d4/new_word.php#L76
@HugoFara I can't reproduce this bug, but found another bug #170. I'm on d246f05.
|
I haven't been able to reproduce the bug either, and no comments came here so it may have been fixed at some point, I'm closing it for now. |
Okayyyy figured it out while documenting the functions! Bug steps/call stackBasically they steps are:
To reproduceHave the same expression in several texts. For the futureI should simplify the call stack to: Create expression (JS) That should remove the back and forth. For nowAt step 2, I added a text key in the array. Step 3 uses it to update only the current text. I won't it won't cause issues until I implement the clean version. That was a nice and nasty bug, cheers! |
New databse migration strategy. Fixes feeds (#168). Adds missing documentation to Docker (#146, #160). Changes in PHP and JS globals. Fixes reading position was not set. Read text through API (#153, #155). Fixes word was not saved/deleted. Fixes #170 and #69. Updates API (#175). Adds dependency to php-xml (#178, #181). Updates makefile (#179). Adds MeCab support on Mac (#135). Adds the option to hide/show word romanization (#119). Raises URL size limit to 2048 (#144).
Prior to adding the new phrase "Con el tiempo":
After! :-)
On page reload, the highlight is where it should be:
Mac/chrome ... I'm investigating a fix now.
The text was updated successfully, but these errors were encountered: